[webkit-reviews] review granted: [Bug 61528] Implement maxWidth check for canvas fill/strokeText : [Attachment 115032] Fixes the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 61528: Implement maxWidth check for canvas fill/strokeText
https://bugs.webkit.org/show_bug.cgi?id=61528

Attachment 115032: Fixes the
canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test
https://bugs.webkit.org/attachment.cgi?id=115032&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115032&action=review


Looks good.  Thanks for the test coverage!  r=me

> LayoutTests/ChangeLog:22
> +	   * resources/Ahem.ttf: Added.

(There already look to be at least 5 copies of Ahem.ttf in the tree, but Philip
tells me he has a followup patch to consolidate all the copies).

> LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:60
> +}, 50);

Hmm.  This timeout looks like it could introduce flakiness on a heavily-loaded
machine (which our layout test bots tend to be).  Unfortunately, I don't know
of a way to an onload for @fontface, so I don't have any bright ideas here.