[webkit-reviews] review granted: [Bug 37325] SVG Padding stops mouse events : [Attachment 115086] Fix SVG hit testing when padding is present and add associated test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 06:20:12 PST 2011


Nikolas Zimmermann <zimmermann at kde.org> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 37325: SVG Padding stops mouse events
https://bugs.webkit.org/show_bug.cgi?id=37325

Attachment 115086: Fix SVG hit testing when padding is present and add
associated test
https://bugs.webkit.org/attachment.cgi?id=115086&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115086&action=review


Looks great to me, please update the comment and land manually, or reuploaded
it and I'll set the flags again.

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:431
>      // Note: For now, we're ignoring hits to border and padding for <svg>

This comment is invalid now, no?


More information about the webkit-reviews mailing list