[webkit-reviews] review granted: [Bug 15598] font property does not show up as "shorthand" in inspector : [Attachment 115139] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 15598: font property does not show up as "shorthand" in inspector
https://bugs.webkit.org/show_bug.cgi?id=15598

Attachment 115139: Patch
https://bugs.webkit.org/attachment.cgi?id=115139&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115139&action=review


Looks great, r=me! Assuming everything turns green, it's ready to land.

> Source/WebCore/css/CSSStyleSelector.cpp:2396
> +void CSSStyleSelector::applyPropertyToCurrentStyle(int id, CSSValue *value)

"CSSValue* value". No idea why style bot doesn't complain here :-)

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1999
> +    // As described in BUG66291, setting font-size on a font may entail a
CSSPrimitiveValue::computeLengthDouble call,
> +    // which assumes the fontMetrics are available for the affected font,
otherwise a crash occurs (see http://trac.webkit.org/changeset/96122).
> +    // The updateFont() call below updates the fontMetrics and ensures the
proper setting of font-size.

Excellent, that's the information you want to read :-)