[webkit-reviews] review requested: [Bug 71082] [Qt][WK2] Implement favicon support : [Attachment 115075] Addressing caio's comments on previous patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 17:56:54 PST 2011


Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 71082: [Qt][WK2] Implement favicon support
https://bugs.webkit.org/show_bug.cgi?id=71082

Attachment 115075: Addressing caio's comments on previous patch.
https://bugs.webkit.org/attachment.cgi?id=115075&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
Thanks Caio for the review. I've had some trouble when I've changed the
header/source files to "_p" suffix, so I have to include it differently now on
plugin.cpp. I did the changes you proposed, let me know if there's something
missing or needing improvement. On MiniBrowser, we only display the favicon for
the current page (previously I had a click event there to show how to cleanup
the database).

I've tried to explain a bit more on ChangeLog, hope it was clear enough and not
too long. :)


More information about the webkit-reviews mailing list