[webkit-reviews] review granted: [Bug 70421] V8 bindings: event listener can be garbage collected, causing events loss : [Attachment 115043] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eugene Nalimov <enal at google.com>'s
request for review:
Bug 70421: V8 bindings: event listener can be garbage collected, causing events
loss
https://bugs.webkit.org/show_bug.cgi?id=70421

Attachment 115043: Patch
https://bugs.webkit.org/attachment.cgi?id=115043&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115043&action=review


I'm happy with the code change.  I'm less excited about the long test.	Below
are some extremely minor style nits.  If we can make the test faster, great. 
If not, we can live with it.

> Source/WebCore/bindings/v8/V8GCController.cpp:167
> +struct SpecialCasePrologueNodeHandler {

Normally we'd use "class" for traits classes.

> Source/WebCore/bindings/v8/V8GCController.cpp:174
> +template<typename T, typename S> class GCPrologueVisitor : public
DOMWrapperMap<T>::Visitor {

Usually we have a line break before "class" in these template declarations.