[webkit-reviews] review canceled: [Bug 71758] URLs are encoded in UTF-8, then decoded as if they are Latin1 : [Attachment 114624] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 16:54:10 PST 2011


Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 71758: URLs are encoded in UTF-8, then decoded as if they are Latin1
https://bugs.webkit.org/show_bug.cgi?id=71758

Attachment 114624: Patch
https://bugs.webkit.org/attachment.cgi?id=114624&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #22)
> A pointer is a way to have an optional parameter, and is a relatively common
idiom in WebKit when an argument is optional. I’m not sure that using a special
value for a string, such as null or empty, to mean the parameter is not being
passed is quite as clear.

As you wish, I don't have a strong opinion against this. I'll post an update.


More information about the webkit-reviews mailing list