[webkit-reviews] review granted: [Bug 72324] DFG put_by_id transition optimizations test the wrong structures : [Attachment 115053] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 72324: DFG put_by_id transition optimizations test the wrong structures
https://bugs.webkit.org/show_bug.cgi?id=72324

Attachment 115053: the patch
https://bugs.webkit.org/attachment.cgi?id=115053&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115053&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1825
> +			       if
(previousStructure->storedPrototype().isCell())

I would prefer if the 'isCell' check check was a !isNull() check for
consistency.