[webkit-reviews] review denied: [Bug 72316] [MutationObservers] Add histogram collection for usage of DOM Mutation Events : [Attachment 115041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 15:27:07 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 72316: [MutationObservers] Add histogram collection for usage of DOM
Mutation Events
https://bugs.webkit.org/show_bug.cgi?id=72316

Attachment 115041: Patch
https://bugs.webkit.org/attachment.cgi?id=115041&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115041&action=review


> Source/WebCore/dom/Document.cpp:499
> +static void histogramMutationEventUsage(const unsigned short& listenerTypes)

> +{
> +   
PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOM
SubtreeModified", listenerTypes & Document::DOMSUBTREEMODIFIED_LISTENER, 2);

I don't these functions are available on non-Chromium ports. You need to wrap
it in #if PLATFORM(CHROMIUM)


More information about the webkit-reviews mailing list