[webkit-reviews] review granted: [Bug 71747] DateMath.cpp should not depend on JavaScriptCore : [Attachment 115014] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 71747: DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747

Attachment 115014: Patch
https://bugs.webkit.org/attachment.cgi?id=115014&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115014&action=review


>> Source/JavaScriptCore/runtime/JSDateMath.cpp:76
>>  #include "ASCIICType.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

It’s true, ASCIICType.h should come before Assertions.h.

> Source/JavaScriptCore/runtime/JSDateMath.cpp:82
>  #include "Assertions.h"
>  #include "ASCIICType.h"
>  #include "CurrentTime.h"
> -#if USE(JSC)
>  #include "JSObject.h"
> -#endif
>  #include "MathExtras.h"
> -#if USE(JSC)
>  #include "ScopeChain.h"
> -#endif
>  #include "StdLibExtras.h"
>  #include "StringExtras.h"

Is there a chance we could cut these includes down a bit more? Guess someone
can look into that later.

> Source/JavaScriptCore/wtf/DateMath.h:108
> +using WTF::isLeapYear;
>  using WTF::dateToDaysFrom1970;

Entire "using" list should be sorted alphabetically.