[webkit-reviews] review canceled: [Bug 61528] Implement maxWidth check for canvas fill/strokeText : [Attachment 114559] Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 14 14:26:43 PST 2011
Philip Rogers <pdr at google.com> has canceled Philip Rogers <pdr at google.com>'s
request for review:
Bug 61528: Implement maxWidth check for canvas fill/strokeText
https://bugs.webkit.org/show_bug.cgi?id=61528
Attachment 114559: Implement maxWidth for fillText and strokeText, fixing the
canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
https://bugs.webkit.org/attachment.cgi?id=114559&action=review
------- Additional Comments from Philip Rogers <pdr at google.com>
Replying to review Stephen White and attaching updated patch.
* A comment here might be helpful. Do we really want to do a zero X scale in
this case, or should we just skip drawing altogether if fontWidth is zero?
I added a comment about the composite operations (like copy) requiring this.
* Also, is this code path (gradient/pattern text) covered by the given tests?
Nice catch, they were not. I added the 2d.text.draw.fill.maxWidth.gradient test
and made sure it fails on webkit but passes after this patch is applied.
More information about the webkit-reviews
mailing list