[webkit-reviews] review granted: [Bug 72295] JS Test Harness: Use a data url for the stylesheet to reduce flakiness : [Attachment 115001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 13:48:18 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 72295: JS Test Harness: Use a data url for the stylesheet to reduce
flakiness
https://bugs.webkit.org/show_bug.cgi?id=72295

Attachment 115001: Patch
https://bugs.webkit.org/attachment.cgi?id=115001&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115001&action=review


> LayoutTests/ChangeLog:7
> +

Can you add more details here about how this reduces flakiness? Just a couple
lines that matches what you told me in person.

> LayoutTests/ChangeLog:9
> +	   ():

FYI, in the future, you can remove these dummy lines. The prepare-changelog
parsing doesn't work very well for JS.


More information about the webkit-reviews mailing list