[webkit-reviews] review granted: [Bug 72276] Web Inspector: Command line $x fails for 3 of 4 types of XPath query : [Attachment 114973] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 14 13:45:02 PST 2011
Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 72276: Web Inspector: Command line $x fails for 3 of 4 types of XPath query
https://bugs.webkit.org/show_bug.cgi?id=72276
Attachment 114973: Patch
https://bugs.webkit.org/attachment.cgi?id=114973&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review
r+ is you land it with the style fixed.
> Source/WebCore/inspector/InjectedScriptSource.js:600
> + case XPathResult.NUMBER_TYPE: return result.numberValue;
> + case XPathResult.STRING_TYPE: return result.stringValue;
> + case XPathResult.BOOLEAN_TYPE: return result.booleanValue;
The case and the return should be on seperate lines.
More information about the webkit-reviews
mailing list