[webkit-reviews] review denied: [Bug 71010] introduce a way to grab performance counters from Inspector UI Performance tests. : [Attachment 115017] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 71010: introduce a way to grab performance counters from Inspector UI
Performance tests.
https://bugs.webkit.org/show_bug.cgi?id=71010

Attachment 115017: Patch
https://bugs.webkit.org/attachment.cgi?id=115017&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I'm sorry, but I'd like to back up a step or two and understand what the
purpose of this flag and these numbers are before we land this - you are using
NRWT in a way that looks like it is fairly different from the way we normally
run it, and I'd like to understand it better to ensure that there isn't a
better way to accomplish what you're trying to accomplish.

All of the other tests generate output to stdout and then that output is
compared to references (as I'm sure you know). When you use these performance
counters, is the only point of the test to get these numbers, or are they
supposed to be used for correctness as well? Is this data only ever going to be
used by a developer running these tests interactively, or does this data get
generated (and stored) on the bots? Are the performance counters generated for
every test run, or only in tests that are triggered by some call in the test
script (via LayoutTestController or something else)?

Also, this data is being written into the logs, but it seems like you might
actually want it to be considered part of the test output, and maybe it should
be stored in test_results so that it shows up in the HTML results (and in the
JSON) as well?