[webkit-reviews] review granted: [Bug 71916] [chromium] scroll deltas are cleared during commit to the main thread : [Attachment 115007] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 13:14:44 PST 2011


James Robinson <jamesr at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 71916: [chromium] scroll deltas are cleared during commit to the main
thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Attachment 115007: Patch
https://bugs.webkit.org/attachment.cgi?id=115007&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Looks good.

For the common code, I think it'd make more sense to have these details hidden
in the getter on the CCLayerImpl side rather than having the common code need
to be aware of every bit of information. For example, we could add a getter for
'the current position including all of your local scroll stuff' that is trivial
on the LayerChromium impl and adds in all the appropriate values on the
CCLayerImpl side


More information about the webkit-reviews mailing list