[webkit-reviews] review denied: [Bug 68691] new-run-webkit-tests is locale dependent : [Attachment 115013] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied vanuan at gmail.com's request for review:
Bug 68691: new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Attachment 115013: Patch
https://bugs.webkit.org/attachment.cgi?id=115013&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok, one last step.  You should unittest this.  It's very simple.  See
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/b
ase_unittest.py  Add a test_setup_environ_for_server(self) test which uses
self.assertEquals(env['LANGUAGE'], 'en'), etc. to verify that these are set
correctly, and then run test-webkitpy to make sure everything still works.

That's the final piece.  Otherwise looks great.  Thank you for your efforts.