[webkit-reviews] review granted: [Bug 72196] Remove the CSS3_FLEXBOX compile time flag and enable on all ports : [Attachment 114984] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 12:14:16 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 72196: Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196

Attachment 114984: Patch
https://bugs.webkit.org/attachment.cgi?id=114984&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114984&action=review


> Source/WebCore/css/CSSValueKeywords.in:329
>  -webkit-box
>  -webkit-inline-box
> --wap-marquee
>  -webkit-flexbox
>  -webkit-inline-flexbox
> +-wap-marquee

I'm not convinced this is correct. I expect this is dead code, but this should
be a separate patch.


More information about the webkit-reviews mailing list