[webkit-reviews] review granted: [Bug 72083] Switch table indexing to unsigned : [Attachment 114614] Proposed change.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 72083: Switch table indexing to unsigned
https://bugs.webkit.org/show_bug.cgi?id=72083

Attachment 114614: Proposed change.
https://bugs.webkit.org/attachment.cgi?id=114614&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114614&action=review


> Source/WebCore/ChangeLog:18
> +	   The only exception is reverse iterating over the array
> +	   as I did not find a good way of doing that without using
> +	   an unsigned (tried all of the usual suggestions but they
> +	   keep failing locally and using do { } while () is worse).
> +	   Due to the size limits on the columns and rows added in
> +	   bug 71135, it should be difficult to overflow the integer
> +	   in some cases.

for (unsigned i = size; i; ) {
	--i;
	// Body of loop goes here.
    }