[webkit-reviews] review granted: [Bug 71059] run-leaks does not work on Lion? : [Attachment 114997] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 12:01:45 PST 2011


Adam Roben (:aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 71059: run-leaks does not work on Lion?
https://bugs.webkit.org/show_bug.cgi?id=71059

Attachment 114997: Patch v1
https://bugs.webkit.org/attachment.cgi?id=114997&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114997&action=review


> Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:36
> +eval "package RunLeaks; sub {" .
read_file(File::Spec->catfile($FindBin::Bin, "../..", "run-leaks")) . "}";

It would be a little better to use "..", ".." instead of "../..". Ditto for
your other test scripts.


More information about the webkit-reviews mailing list