[webkit-reviews] review requested: [Bug 71082] [Qt][WK2] Implement favicon support : [Attachment 114991] Use a QDeclarativeImageProvider to display FavIcons instead of creating a new component
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 14 11:10:05 PST 2011
Rafael Brandao <rafael.lobo at openbossa.org> has asked for review:
Bug 71082: [Qt][WK2] Implement favicon support
https://bugs.webkit.org/show_bug.cgi?id=71082
Attachment 114991: Use a QDeclarativeImageProvider to display FavIcons instead
of creating a new component
https://bugs.webkit.org/attachment.cgi?id=114991&action=review
------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
QtWebIconDatabase requests a favicon once the webview changes its url, and then
it associates an id for the favicon requested. All pages that has the same url
will share the same favicon, so they receive the same favicon id and sets its
favicon source url with that id. That url will request the icon from
QtWebFavIconImageProvider which will access QtWebIconDatabase's favicon storage
to get the QPixmap.
More information about the webkit-reviews
mailing list