[webkit-reviews] review denied: [Bug 71724] Optimize double border and outline rendering to avoid transparency layers : [Attachment 114203] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied David Barr
<davidbarr at chromium.org>'s request for review:
Bug 71724: Optimize double border and outline rendering to avoid transparency
layers
https://bugs.webkit.org/show_bug.cgi?id=71724

Attachment 114203: Patch
https://bugs.webkit.org/attachment.cgi?id=114203&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114203&action=review


Do we have any pixel tests for double outlines? If not, we should.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1624
> +static void calculateThirds(const BorderEdge edges[], RoundedRect&
outerThird, RoundedRect& innerThird)

Can we use this new method in an existing code?

> Source/WebCore/rendering/RenderObject.cpp:1158
> +		   // We need certain integer rounding results
> +		   if (outlineWidth % 3 == 2)
> +		       outerWidth += 1;
> +		   if (outlineWidth % 3 == 1)
> +		       innerWidth += 1;
> +		   LayoutRect innerThird = outer;

This is copied from BorderEdge::getDoubleBorderStripeWidths(). Please share
that code.