[webkit-reviews] review granted: [Bug 72258] [GTK] Implement download support in WebKit2 : [Attachment 114921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 10:17:29 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 72258: [GTK] Implement download support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72258

Attachment 114921: Patch
https://bugs.webkit.org/attachment.cgi?id=114921&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114921&action=review


Looks good, but I'm not sure the changes in
Source/WebKit/gtk/webkit/webkitdownload.cpp are necessary...

> Source/WebKit/gtk/webkit/webkitdownload.cpp:476
> +	   webkitDownloadEmitError(download,
downloadDestinationError(core(priv->networkResponse), error->message));

It It seems like this code is just using the ResourceError to carry the message
and the error code to webkitDownloadEmitError. Why not just pass the error code
and the message directly?


More information about the webkit-reviews mailing list