[webkit-reviews] review granted: [Bug 71911] [Qt] Enable skipped but now passing tests (http/tests) : [Attachment 114930] http-unskip

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Zoltan Arvai
<zarvai at inf.u-szeged.hu>'s request for review:
Bug 71911: [Qt] Enable skipped but now passing tests (http/tests)
https://bugs.webkit.org/show_bug.cgi?id=71911

Attachment 114930: http-unskip
https://bugs.webkit.org/attachment.cgi?id=114930&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114930&action=review


Otherwise LGTM, let's land it tomorrow after one more test.

> LayoutTests/platform/qt/Skipped:-2178
> -# new test introduced in r88958, but fail on Qt
> -# https://bugs.webkit.org/show_bug.cgi?id=62741
> -http/tests/appcache/video.html

This test still fails for me.

>> LayoutTests/platform/qt/Skipped:-2494
>> -# [Qt] http/tests/notifications/icon-does-not-exist.html makes
fast/notifications/notifications-click-event.html fail
>> -# https://bugs.webkit.org/show_bug.cgi?id=71693
>> -http/tests/notifications/icon-does-not-exist.html
>> -
> 
> We shouldn't remove this one, because it makes
fast/notifications/notifications-click-event.html :)

We shouldn't remove this one, because it makes
fast/notifications/notifications-click-event.html :)