[webkit-reviews] review requested: [Bug 72267] [GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings : [Attachment 114949] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 72267: [GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=72267

Attachment 114949: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=114949&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #6)
> [...]
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:615
> > +	 /**
> > +	 * WebKitSettings:enable-caret-browsing:
> > +	 *
> indentation is wrong here.

Fixed.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:616
> > +	 * Whether to enable caret browsing mode.
> 
> hmm, maybe you could explain a bit what caret browsing means, or use
"accessibility enhanced keyboard navigation" here too.

Done.