[webkit-reviews] review requested: [Bug 47467] SVG <path> DRT dumps have rounding problems across platforms : [Attachment 114917] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 04:42:38 PST 2011


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 47467: SVG <path> DRT dumps have rounding problems across platforms
https://bugs.webkit.org/show_bug.cgi?id=47467

Attachment 114917: Patch v1
https://bugs.webkit.org/attachment.cgi?id=114917&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
New attempt at fixing the rounding problems across the Gtk/Win bots.
It fixes all 0.0 vs -0.0 issues, several wrong sizes that are reported in the
mac dumps 481x360 -> 480x360.
This includes a patch from Zoltan to SVGPreserveAspectRatio::getCTM(), to avoid
loosing precision, by using double internally. The AffineTransform that
getCTM() generates uses double values, that's why this matters!


More information about the webkit-reviews mailing list