[webkit-reviews] review granted: [Bug 70421] V8 bindings: event listener can be garbage collected, causing events loss : [Attachment 114561] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eugene Nalimov <enal at google.com>'s
request for review:
Bug 70421: V8 bindings: event listener can be garbage collected, causing events
loss
https://bugs.webkit.org/show_bug.cgi?id=70421

Attachment 114561: Patch
https://bugs.webkit.org/attachment.cgi?id=114561&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114561&action=review


This is a nice solution.  Any idea why the test is failing?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1700
> +    # A DOMObject that is an ActiveDOMObject and also a DOMNode should be
treated as an DOMNode here.

Can you explain a bit more why?  I would naively expect ActiveDOMNode here.

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:95
> -    getDOMNodeMap().set(node, wrapper);
> +    if (node->isActiveNode())

I hope this doesn't slow us down on DOM benchmarks.  Please ping the perf
sheriff when landing.