[webkit-reviews] review requested: [Bug 71854] Access key should work on all elements : [Attachment 114851] Updated patch as per review comments to fix mac builds.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 12 21:32:56 PST 2011


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 71854: Access key should work on all elements
https://bugs.webkit.org/show_bug.cgi?id=71854

Attachment 114851: Updated patch as per review comments to fix mac builds.
https://bugs.webkit.org/attachment.cgi?id=114851&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #23)
> This is easy to fix. You need to update
Source/WebCore/bindings/objc/PublicDOMInterfaces.h and add accessKey to
DOMHTMLElement	and remove it from all the its subclasses.

Sorry for delayed response and inconvenience caused.
As I see this patch was rolled-out in http://trac.webkit.org/changeset/100076.

Thanks Erik for help but unfortunately I don't have access to MAC
machine/build. Still I have updated PublicDOMInterfaces.h moving accessKey from
subclasses to base class but needs to be verified. 
It would be great help if someone with MAC access helps verifying this new
patch.


More information about the webkit-reviews mailing list