[webkit-reviews] review granted: [Bug 72000] [CMAKE] Add the UseV8.cmake to WebCore. : [Attachment 114827] Add the UseV8.cmake to WebCore to build bindings of V8 and generate JavaScript codes given IDL input.

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted jaehoon jeong
<jh4u.jeong at samsung.com>'s request for review:
Bug 72000: [CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Attachment 114827: Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.
https://bugs.webkit.org/attachment.cgi?id=114827&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114827&action=review


This looks sane to me. I have some minor nits.

> Source/WebCore/UseV8.cmake:15
> +LIST(APPEND WebCore_SOURCES

Please sort the entires in this list so that they appear in sorted order as
produced by the Unix sort command.

> Source/WebCore/UseV8.cmake:167
> +LIST(APPEND WebCore_SOURCES
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrPattern.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrInterpreter.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrJIT.cpp
> +    ${JAVASCRIPTCORE_DIR}/yarr/YarrSyntaxChecker.cpp

Ditto.