[webkit-reviews] review granted: [Bug 72212] [CMake] Move list of DFG source files into correct file : [Attachment 114831] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 72212: [CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Attachment 114831: Patch
https://bugs.webkit.org/attachment.cgi?id=114831&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114831&action=review


> Source/JavaScriptCore/CMakeLists.txt:57
> +    dfg/DFGJITCodeGenerator64.cpp
> +    dfg/DFGJITCodeGenerator32_64.cpp

These entries should be reversed so that they appear in sorted order as
produced by the Unix sort command.

> Source/JavaScriptCore/CMakeLists.txt:59
> +    dfg/DFGOperations.cpp

This entry should be above dfg/DFGPropagator.cpp so that it appears in this
list in sorted order as produced by the Unix sort command.

> Source/JavaScriptCore/CMakeLists.txt:64
> +    dfg/DFGOSRExitCompiler64.cpp
> +    dfg/DFGOSRExitCompiler32_64.cpp

These entries should be reversed so that they appear in sorted order as
produced by the Unix sort command.

> Source/JavaScriptCore/CMakeLists.txt:69
> +    dfg/DFGSpeculativeJIT64.cpp
> +    dfg/DFGSpeculativeJIT32_64.cpp

Ditto.