[webkit-reviews] review granted: [Bug 71903] [chromium] Missing wait() in CCThreadProxy::setVisible : [Attachment 114745] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 17:19:39 PST 2011


James Robinson <jamesr at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 71903: [chromium] Missing wait() in CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

Attachment 114745: Patch
https://bugs.webkit.org/attachment.cgi?id=114745&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114745&action=review


>> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:214
>> +	    callOnMainThread(visible ? CCLayerTreeHostTest::dispatchSetVisible
: CCLayerTreeHostTest::dispatchSetInvisible, this);
> 
> is this because callOnMainThread doesn't support args? Its fine if that's the
case.

Yeah I think (this part is from Iain's patch, but that's the reason I would
have guessed).


More information about the webkit-reviews mailing list