[webkit-reviews] review granted: [Bug 70452] Implement storage and retrieval of TextTrackCues during video playback. : [Attachment 114764] addressing reviewer comments and updating to ToT

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 70452: Implement storage and retrieval of TextTrackCues during video
playback.
https://bugs.webkit.org/show_bug.cgi?id=70452

Attachment 114764: addressing reviewer comments and updating to ToT
https://bugs.webkit.org/attachment.cgi?id=114764&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114764&action=review


>> Source/WebCore/html/HTMLMediaElement.cpp:-507

> 
> I believe this is no longer needed here because it is covered by
trackWasAdded().  eric.carlson, please check my logic here as you recently
added this.

There is a problem, but I think it is that HTMLMediaElement::addTextTrack
should call scheduleLoad(TextTrackResource) instead of configureTextTracks()
because we need to start the load asynchronously.


> Source/WebCore/html/HTMLMediaElement.cpp:1965
> +    float movieTime = currentTime();
> +    updateActiveTextTrackCues(movieTime);

Nit: the local variable isn't necessary.


> Source/WebCore/html/HTMLTrackElement.cpp:157
> +	   m_track = LoadableTextTrack::create(scriptExecutionContext(), this,
kind(), label(), srclang(), isDefault());

You shouldn't need to pass a ScriptExecutionContext, the track can use the
Document associated with the track element for the ScriptExecutionContext.