[webkit-reviews] review denied: [Bug 72188] Expose compositeAndReadback in WebLayerTreeView : [Attachment 114777] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied vollick at chromium.org's request
for review:
Bug 72188: Expose compositeAndReadback in WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=72188

Attachment 114777: Patch
https://bugs.webkit.org/attachment.cgi?id=114777&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114777&action=review


> Source/WebKit/chromium/public/WebLayerTreeView.h:86
> +					       int width,
> +					       int height);

this should not line wrap and it should use a WebSize parameter instead of a
pair of ints

can you document the ownership model and requirements of the pixels buffer, and
what goes into them (pretty sure it's rgba values)

you also need to document the return value and what happens to *pixels when
this function returns false

> Source/WebKit/chromium/src/WebLayerTreeView.cpp:93
> +	   pixels, WebCore::IntRect(0, 0, width, height));

don't line wrap this either