[webkit-reviews] review granted: [Bug 72187] Update iOS port's configuration setting, particularly in Platform.h : [Attachment 114776] Fix

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 72187: Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Attachment 114776: Fix
https://bugs.webkit.org/attachment.cgi?id=114776&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114776&action=review


r=me

>> Source/JavaScriptCore/wtf/FastMalloc.cpp:1952
>> +  static const size_t kDefaultReleaseDelay = 64;
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

Please fix this style issue.

> Source/JavaScriptCore/wtf/FastMalloc.cpp:1977
> +#if PLATFORM(IOS)
> +	 scavenge_counter_ = std::max<size_t>(16UL,
std::min<size_t>(kDefaultReleaseDelay, kDefaultReleaseDelay - (free_pages_ /
kDefaultReleaseDelay)));
> +#else
>	 scavenge_counter_ = std::max<size_t>(64UL,
std::min<size_t>(kDefaultReleaseDelay, kDefaultReleaseDelay - (free_pages_ /
kDefaultReleaseDelay)));
> +#endif

Nit: We could pull out 16UL and 64UL into constants in a future commit so we
only have to use macros around the value.