[webkit-reviews] review granted: [Bug 71575] WebSQLDatabase could use some better error reporting. : [Attachment 114784] dberrors

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 71575: WebSQLDatabase could use some better error reporting.
https://bugs.webkit.org/show_bug.cgi?id=71575

Attachment 114784: dberrors
https://bugs.webkit.org/attachment.cgi?id=114784&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114782&action=review


Tnis could go in as is. Here are some nice to haves but not critical:
 Would be nice to clean up the duplicate strings.

> Source/WebCore/storage/ChangeVersionWrapper.cpp:55
> +					
transaction->database()->sqliteDatabase().lastErrorMsg());

Somehow the repeat of "transaction->database()->sqliteDatabase()" bothers me.
(It would be nice to do only once.)

> Source/WebCore/storage/ChangeVersionWrapper.cpp:74
> +					
transaction->database()->sqliteDatabase().lastErrorMsg());

Ditto.