[webkit-reviews] review granted: [Bug 72175] Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X : [Attachment 114763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 13:51:26 PST 2011


Joseph Pecoraro <joepeck at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 72175: Only define BUILDING_ON_* and TARGETING_* macros when building for
Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72175

Attachment 114763: Patch
https://bugs.webkit.org/attachment.cgi?id=114763&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114763&action=review


> Source/JavaScriptCore/wtf/Platform.h:327
> +    || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)		    \

Might as well fix the end of line spacing on this line. Either have the "\"s
line up
(like I think is normal for macros) or just one space after the line.


More information about the webkit-reviews mailing list