[webkit-reviews] review requested: [Bug 72175] Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X : [Attachment 114763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 13:37:51 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 72175: Only define BUILDING_ON_* and TARGETING_* macros when building for
Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72175

Attachment 114763: Patch
https://bugs.webkit.org/attachment.cgi?id=114763&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
<http://webkit.org/b/NNNNN>

Reviewed by NOBODY (OOPS!).

* wtf/Platform.h: Move the definition of the BUILDING_ON_* and
TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds.  Also include
Availability.h, which is needed on iOS builds.
---
 2 files changed, 25 insertions(+), 13 deletions(-)


More information about the webkit-reviews mailing list