[webkit-reviews] review denied: [Bug 72028] [chromium] Plumb through partial swap : [Attachment 114734] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Jonathan Backer
<backer at chromium.org>'s request for review:
Bug 72028: [chromium] Plumb through partial swap
https://bugs.webkit.org/show_bug.cgi?id=72028

Attachment 114734: Patch
https://bugs.webkit.org/attachment.cgi?id=114734&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114734&action=review


Looks fine overall; one question/comment. r- for the ChangeLog issue; please
upload a new patch fixing that.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This OOPS needs to be removed from the ChangeLog.

> Source/WebKit/chromium/public/WebGraphicsContext3D.h:166
> +    // GL_CHROMIUM_post_sub_buffer - Copies part of the back buffer to the
front buffer.

This documentation should (also) be added to the declaration of the extension
in Chromium's gl2ext.h.

Has chromium_rev in Source/WebKit/chromium/DEPS already been rolled forward to
the revision containing the concrete implementations of this method?