[webkit-reviews] review granted: [Bug 71718] Apparent threading bug causes intermittent segfaults : [Attachment 114733] fix for static local race condition

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 71718: Apparent threading bug causes intermittent segfaults
https://bugs.webkit.org/show_bug.cgi?id=71718

Attachment 114733: fix for static local race condition 
https://bugs.webkit.org/attachment.cgi?id=114733&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114733&action=review


r=me on the condition that initializeThreading() change is removed before
landing.

> Source/JavaScriptCore/wtf/qt/ThreadingQt.cpp:152
> +	   threadMap();

This change is not mentioned in ChangeLog, is unnecessary, and is not something
ThreadingPthreads does. All accesses to threadMap are protected by
threadMapMutex, so there is no need to create it upfront.