[webkit-reviews] review granted: [Bug 72156] build-webkit: Accept --cmakeargs to pass additional arguments to CMake. : [Attachment 114738] Add an example to the usage message

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 11:20:59 PST 2011


Daniel Bates <dbates at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 72156: build-webkit: Accept --cmakeargs to pass additional arguments to
CMake.
https://bugs.webkit.org/show_bug.cgi?id=72156

Attachment 114738: Add an example to the usage message
https://bugs.webkit.org/attachment.cgi?id=114738&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review


> Tools/Scripts/build-webkit:62
> +my $cmakeArgs = "";

Nit: It's unnecessary to explicitly initialize this variable. Notice, both the
empty string and an undefined value evaluate to 0 (false) on line 1644 of this
patch.


More information about the webkit-reviews mailing list