[webkit-reviews] review granted: [Bug 72125] Web Inspector: reimplement DOM search using no XPath. : [Attachment 114702] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 72125: Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Attachment 114702: Patch
https://bugs.webkit.org/attachment.cgi?id=114702&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114702&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:793
> +    if (!whitespaceTrimmedQuery.find("//")) {

Can we always fall back to XPath as before, otherwise it may be confusing that
we limit supported XPath patterns to "//..."?

> Source/WebCore/inspector/InspectorDOMAgent.cpp:856
> +			   const Attribute *attribute =
attrMap->attributeItem(i);

const Attribute* attribute for consistency with other places.