[webkit-reviews] review requested: [Bug 70897] Use a simple page client/controller for user consent in getUserMedia() : [Attachment 114706] Patch 4

[bugzilla-daemon at webkit.org]

Adam Bergkvist <adam.bergkvist at ericsson.com> has asked	for review:
Bug 70897: Use a simple page client/controller for user consent in
getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=70897

Attachment 114706: Patch 4
https://bugs.webkit.org/attachment.cgi?id=114706&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
(In reply to comment #26)
> (From update of attachment 114476 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=114476&action=review
> 
> > Source/WebCore/mediastream/UserMediaController.cpp:82
> > +	 ASSERT(m_requests.contains(request));
> 
> This function needs to be part of UserMediaController to use m_requests

Fixed.

> > Source/WebCore/mediastream/UserMediaController.cpp:87
> > +	 ScriptExecutionContext* context = request->frame()->document();
> 
> Need to #include "Document.h" for this to compile.

Fixed.

> > Source/WebCore/mediastream/UserMediaRequest.cpp:58
> > +	 , m_scriptExecutionContext(frame->document())
> 
> Need to #include "Document.h" for this to compile.

Fixed.