[webkit-reviews] review granted: [Bug 68996] [GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings : [Attachment 114623] Incorporated review comments

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68996: [GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Attachment 114623: Incorporated review comments
https://bugs.webkit.org/attachment.cgi?id=114623&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114623&action=review


Looks good, but please fix the small things below when landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:509
> +							   _("Sans-serif font
Family"),

Nit: Familly is capitalized here, but not above.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:523
> +							   _("Cursive font
Family"),

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:581
> +							 _("Default monospace
font Size"),

Same issue for "Size"

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:590
> +    * controls how the absolute smallest size fonts will be rendered. Values


This is a little unclear. Might be better as "controls the absolute smallest
size"