[webkit-reviews] review requested: [Bug 15365] [CSS2.1] Anonymous tables should be inline/block-level based off tbody's parent box : [Attachment 114680] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 05:14:51 PST 2011


Kanghao (Kenny) Lu <kennyluck at csail.mit.edu> has asked	for review:
Bug 15365: [CSS2.1] Anonymous tables should be inline/block-level based off
tbody's parent box
https://bugs.webkit.org/show_bug.cgi?id=15365

Attachment 114680: proposed patch
https://bugs.webkit.org/attachment.cgi?id=114680&action=review

------- Additional Comments from Kanghao (Kenny) Lu <kennyluck at csail.mit.edu>
A simple try to solve this problem, although I am pretty ignorant about many
CSS details so I am not at all confident about this. I thought about it might
be better to have a m_tableInternal on RenderObject to avoid the isTableXXX
chain but that seems too costly given that this problem shouldn't occur often.

I though this blocks bug 47141 but it turns out that those huge amount of table
anonymous tests don't have a test related to this!

This is my first patch to WebKit, so bear with me.


More information about the webkit-reviews mailing list