[webkit-reviews] review denied: [Bug 70496] Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list : [Attachment 114447] Updated patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 70496: Cannot select multiple options by mouse dragging in <select
multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Attachment 114447: Updated patch
https://bugs.webkit.org/attachment.cgi?id=114447&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114447&action=review


> Source/WebCore/ChangeLog:12
> +	   Test:
fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size
.html

Test coverage is not good.
We should test:
 - Dragging upward in a multiple listbox
 - Dragging in a multiple listbox with "addSelectionKey"
 - Dragging in a multiple listbox with "rangeSelectionKey"
 - Dragging in a non-multiple listbox
 - Dragging in a non-multiple listbox with "addSelectionKey"
 - Dragging in a non-multiple listbox with "rangeSelectionKey"

> Source/WebCore/html/HTMLSelectElement.cpp:1218
> +		   updateSelectedState(listIndex, mouseEvent->ctrlKey(),
mouseEvent->shiftKey());

I found passing ctrlKey() and shiftKey() is meaningless here because they are
required only if m_multiple.