[webkit-reviews] review requested: [Bug 72031] [Qt] Skip tests when no network is present : [Attachment 114644] Updated patch with memory allocation changes reviewed by Simon.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 01:10:58 PST 2011


Bruno Abinader <bruno.de_oliveira at basyskom.de> has asked  for review:
Bug 72031: [Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Attachment 114644: Updated patch with memory allocation changes reviewed by
Simon.
https://bugs.webkit.org/attachment.cgi?id=114644&action=review

------- Additional Comments from Bruno Abinader <bruno.de_oliveira at basyskom.de>
Good point Simon, I always tend to allocate objects on the heap while doing
unit tests so I can delete them on a specific moment if needed. But in this
case, as you said, it is not needed at all.


More information about the webkit-reviews mailing list