[webkit-reviews] review requested: [Bug 70477] [chromium] Improve fullscreen API : [Attachment 114382] v1.5 patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 70477: [chromium] Improve fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=70477

Attachment 114382: v1.5 patch
https://bugs.webkit.org/attachment.cgi?id=114382&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114382&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:1060
> +    if (m_provisionalFullScreenElement) {

This code switches from retaining the fullscreen element to only retaining
the fullscreen frame to make the subsequence code in didEnterFullScreen,
willExitFullScreen and didExitFullScreen more obvious.	In those functions,
given only a frame, it is necessary to get the document, and check if it
has a fullscreen element before asking the document to operate on its 
fullscreen element.

I think there is some work to be done here to move more of this logic into
WebCore, perhaps in the form of a FullScreenController hung off of Page.
With the exception of webkitWillEnterFullScreenForElement, the other methods
completely ignore their parameter, so I just pass null below.