[webkit-reviews] review denied: [Bug 72006] Implement combobox appearance : [Attachment 114616] added test

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 72006: Implement combobox appearance
https://bugs.webkit.org/show_bug.cgi?id=72006

Attachment 114616: added test
https://bugs.webkit.org/attachment.cgi?id=114616&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114616&action=review


> Source/WebCore/platform/mac/ThemeMac.mm:508
> +    HIThemeButtonDrawInfo drawInfo;

The code looks very similar to paintStepper().	Can you share the code with it?


> Source/WebCore/platform/mac/ThemeMac.mm:532
> +    // Center the stepper rectangle in the specified area.

stepper?

> LayoutTests/fast/forms/datalist/combobox-appearance.html:4
> +<script src="../../fast/js/resources/js-test-pre.js"></script>

js-test-pre.js and js-test-post.js are not needed.

> LayoutTests/fast/forms/datalist/combobox-appearance.html:13
> +<p>Test combobox -webkit-appearance</p>

Do not show the unnecessary text.

> LayoutTests/fast/forms/datalist/combobox-appearance.html:20
> +</html>

Please add an expectation image too.