[webkit-reviews] review denied: [Bug 70471] Seaming on border corners with mixed colour alpha borders : [Attachment 111871] Patch for comment (needs test)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ben Wells
<benwells at chromium.org>'s request for review:
Bug 70471: Seaming on border corners with mixed colour alpha borders
https://bugs.webkit.org/show_bug.cgi?id=70471

Attachment 111871: Patch for comment (needs test)
https://bugs.webkit.org/attachment.cgi?id=111871&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111871&action=review


Looks OK but could use a test.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Seems like you could have a pixel test for this.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1409
> +	   bool clipAdjacentSide1 = colorNeedsAntiAliasAtCorner(side,
adjacentSide1, edges) && mitreAdjacentSide1;
> +	   bool clipAdjacentSide2 = colorNeedsAntiAliasAtCorner(side,
adjacentSide1, edges) && mitreAdjacentSide2;

You're calling colorNeedsAntiAliasAtCorner(side, adjacentSide1, edges) twice
here.