[webkit-reviews] review denied: [Bug 72031] [Qt] Skip tests when no network is present : [Attachment 114520] Updated patch which fixes method signature typo.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Bruno Abinader
<bruno.de_oliveira at basyskom.de>'s request for review:
Bug 72031: [Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Attachment 114520: Updated patch which fixes method signature typo.
https://bugs.webkit.org/attachment.cgi?id=114520&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think your patch looks good in general, but I also think that you can
simplify it: Just allocate a QNetworkConfigurationManager instance directly as
member variable. Then you don't need to allocate it on the heap and you don't
need to deal with it in initTestCase().

QNetworkConfigurationManager itself is a pretty lightweight class that just
forwards signals for the actual private singleton. There's no need to allocate
it on the heap :)