[webkit-reviews] review granted: [Bug 72050] Add ARMv7 register info for the DFG JIT : [Attachment 114553] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 10 13:19:17 PST 2011


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 72050: Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050

Attachment 114553: Fix
https://bugs.webkit.org/attachment.cgi?id=114553&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114553&action=review


r=me

> Source/JavaScriptCore/dfg/DFGFPRInfo.h:54
> +    // Only X86_64 passed aguments in xmm registers

typo: passes.

> Source/JavaScriptCore/dfg/DFGFPRInfo.h:60
> +    // Only X86 the return will actually be of the x87 stack,

typo: on. twice.


More information about the webkit-reviews mailing list