[webkit-reviews] review denied: [Bug 68996] [GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings : [Attachment 114461] Incorporated review comments

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68996: [GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Attachment 114461: Incorporated review comments
https://bugs.webkit.org/attachment.cgi?id=114461&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114461&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:475
> +    * The font family used as the default for content marked with a
monospace font.

content marked -> content using

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:489
> +    * The font family used as the default for content marked with a serif
font.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:503
> +    * The font family used as the default for content marked with a
sans-serif font.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:517
> +    * The font family used as the default for content marked with a cursive
font.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:531
> +    * The font family used as the default for content marked with a fantasy
font.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:545
> +    * The font family used as the default for content marked with a
pictograph font.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:560
> +    * The default font size in pixels to use for content displayed if
> +    * no font size or font family is specified.

This seems inaccurate. I believe the default size is used even when a font
family is specified.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:599
> +							 0, G_MAXUINT, 5,

The default value for this property should be zero.